fix(rawdb): correct MemoryFreezer AncientSize by decrementing size on truncation #33344
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
reviewed
Dec 4, 2025
| return errors.New("truncation below tail") | ||
| } | ||
| t.data = t.data[:items-t.offset] | ||
| removeFrom := items - t.offset |
Member
There was a problem hiding this comment.
Probably something like this?
for i := int(items - t.offset); i < len(t.data); i++ {
if t.size > uint64(len(t.data[i])) {
t.size -= uint64(len(t.data[i]))
} else {
t.size = 0
}
}
Contributor
Author
There was a problem hiding this comment.
Probably something like this?
for i := int(items - t.offset); i < len(t.data); i++ { if t.size > uint64(len(t.data[i])) { t.size -= uint64(len(t.data[i])) } else { t.size = 0 } }
good idea, refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AncientSize for the in-memory freezer could over-report because memoryTable.size was not decremented on head or tail truncations. This change subtracts the sizes of removed items in truncateHead and truncateTail, and re-allocates the slice on tail truncation to avoid retaining the backing array. The result brings the in-memory freezer’s size accounting in line with the on-disk freezer’s semantics and the documented meaning of size.